-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add tracks assignment and exposure #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Requires a new experiment-core version to update the version and type. |
|
I'm still getting my bearings on this, so I apologize if is a trivial question: Is the intended use for this meant for to configure tracking on a per fetch request basis or for all requests for a customer? If this is intended to be an option for individual fetch requests to be made with and without tracking, then this seems fine. However, if the feature is meant more for a means for a user to wholesale turn on/off tracking, then it might be a better idea to set this on a client config level to prevent having to remember to set the flags for each place you might call fetch in your codebase. |
This would be for individual fetch requests. Since this is server-side SDK, and an instance of experiment SDK is shared throughout the service lifecycle, each fetch request should be for a different end user. If customer logic determine that we shouldn't track events for this user (ex. bot), then they can do it through these options. |
|
📝 Documentation updates detected! New suggestion: Document FetchOptions for Node.js Experiment SDK |
|
Thanks for the explanation. This makes a lot more sense to me now after looking at some of the other work around this request. 🙏 |
| "@amplitude/analytics-node": "^1.3.4", | ||
| "@amplitude/analytics-types": "^1.3.1", | ||
| "@amplitude/experiment-core": "^0.7.2", | ||
| "@amplitude/experiment-core": "^0.11.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to use 0.12.0 version?
Summary
Adds option to track assignment and exposure events, or not, to fetch requests.
Checklist